lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 28 Sep 2021 22:55:12 -0400
From:   "Martin K. Petersen" <>
To:     Len Baker <>
Cc:     Matthew Wilcox <>,
        Hannes Reinecke <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        "Gustavo A. R. Silva" <>,
        Kees Cook <>,,,
Subject: Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded


> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or
> similar) function arguments due to the risk of them overflowing. This
> could lead to values wrapping around and a smaller allocation being
> made than the caller was expecting. Using those allocations could lead
> to linear overflows of heap memory and other misbehaviors.

Applied to 5.16/scsi-staging, thanks!

Martin K. Petersen	Oracle Linux Engineering

Powered by blists - more mailing lists