lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Sep 2021 22:55:12 -0400 From: "Martin K. Petersen" <martin.petersen@...cle.com> To: Len Baker <len.baker@....com> Cc: Matthew Wilcox <willy@...radead.org>, Hannes Reinecke <hare@...e.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded arithmetic Len, > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or > similar) function arguments due to the risk of them overflowing. This > could lead to values wrapping around and a smaller allocation being > made than the caller was expecting. Using those allocations could lead > to linear overflows of heap memory and other misbehaviors. Applied to 5.16/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists