lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 6 Oct 2021 09:31:24 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, x86@...nel.org,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] sched: task_struct: Fill unconditional hole induced by
 sched_entity

On Wed, Oct 06, 2021 at 11:27:03AM +0200, Peter Zijlstra wrote:
> On Tue, Oct 05, 2021 at 09:48:51PM -0700, Kees Cook wrote:
> > On Thu, Sep 23, 2021 at 07:54:50PM -0700, Kees Cook wrote:
> > > With struct sched_entity before the other sched entities, its alignment
> > > won't induce a struct hole. This saves 64 bytes in defconfig task_struct:
> > 
> > Friendly ping. Can someone snag this for -tip please?
> 
> Hurpmf... if only we had like perf driven pahole output :/

Normally I wouldn't even make suggestions in task_struct given the high
variability due to CONFIG options, but this case was pretty universal.

> Picked it up, we'll see what if anything hurts.

Thanks! *fingers crossed*

-- 
Kees Cook

Powered by blists - more mailing lists