linux-hardening - Re: [PATCH 0/7] wchan: Fix wchan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWgcWnbsvI1rbvEj@shell.armlinux.org.uk>
Date:   Thu, 14 Oct 2021 13:02:34 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     keescook@...omium.org, jannh@...gle.com,
        linux-kernel@...r.kernel.org, vcaputo@...garu.com,
        mingo@...hat.com, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, akpm@...ux-foundation.org,
        christian.brauner@...ntu.com, amistry@...gle.com,
        Kenta.Tada@...y.com, legion@...nel.org,
        michael.weiss@...ec.fraunhofer.de, mhocko@...e.com, deller@....de,
        zhengqi.arch@...edance.com, me@...in.cc, tycho@...ho.pizza,
        tglx@...utronix.de, bp@...en8.de, hpa@...or.com,
        mark.rutland@....com, axboe@...nel.dk, metze@...ba.org,
        laijs@...ux.alibaba.com, luto@...nel.org,
        dave.hansen@...ux.intel.com, ebiederm@...ssion.com,
        ohoono.kwon@...sung.com, kaleshsingh@...gle.com,
        yifeifz2@...inois.edu, jpoimboe@...hat.com,
        linux-hardening@...r.kernel.org, linux-arch@...r.kernel.org,
        vgupta@...nel.org, will@...nel.org, guoren@...nel.org,
        bcain@...eaurora.org, monstr@...str.eu, tsbogend@...ha.franken.de,
        nickhu@...estech.com, jonas@...thpole.se, mpe@...erman.id.au,
        paul.walmsley@...ive.com, hca@...ux.ibm.com,
        ysato@...rs.sourceforge.jp, davem@...emloft.net, chris@...kel.net
Subject: Re: [PATCH 0/7] wchan: Fix wchan support

On Fri, Oct 08, 2021 at 01:15:27PM +0200, Peter Zijlstra wrote:
> Hi,
> 
> This fixes up wchan which is various degrees of broken across the
> architectures.
> 
> Patch 4 fixes wchan for x86, which has been returning 0 for the past many
> releases.
> 
> Patch 5 fixes the fundamental race against scheduling.
> 
> Patch 6 deletes a lot and makes STACKTRACE unconditional
> 
> patch 7 fixes up a few STACKTRACE arch oddities
> 
> 0day says all builds are good, so it must be perfect :-) I'm planning on
> queueing up at least the first 5 patches, but I'm hoping the last two patches
> can be too.
> 
> Also available here:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wchan

These patches introduce a regression on ARM. Whereas before, I have
/proc/*/wchan populated with non-zero values, with these patches they
_all_ contain "0":

root@...arfog21:~# cat /proc/*/wchan
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000root@...arfog21:~#

I'll try to investigate what is going on later today.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!