linux-hardening - Re: [PATCH] nvmet: prefer flex_array_size and struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4c1c399-2332-e594-15e0-bd4883818c58@nvidia.com>
Date:   Wed, 27 Oct 2021 00:13:42 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Len Baker <len.baker@....com>, Keith Busch <kbusch@...nel.org>,
        Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <chaitanyak@...dia.com>
CC:     Kees Cook <keescook@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmet: prefer flex_array_size and struct_size over open
 coded arithmetic

On 10/24/21 10:29 AM, Len Baker wrote:
> External email: Use caution opening links or attachments
> 
> 
> In an effort to avoid open-coded arithmetic in the kernel [1], use the
> flex_array_size() and struct_size() helpers instead of an open-coded
> calculation.
> 
> [1] https://github.com/KSPP/linux/issues/160
> 
> Signed-off-by: Len Baker <len.baker@....com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>