lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 13 Nov 2021 15:20:19 -0800
From:   Linus Torvalds <>
To:     "Gustavo A. R. Silva" <>
Cc:     Kees Cook <>,
        Nathan Chancellor <>,
        Nick Desaulniers <>,
        Linux Kernel Mailing List <>,
Subject: Re: [GIT PULL] Enable -Wimplicit-fallthrough for Clang for 5.16-rc1

On Sat, Nov 13, 2021 at 1:36 PM Gustavo A. R. Silva
<> wrote:
> This patch has been baking in linux-next for a couple of developement
> cycles, now. So, I think we are pretty much ready to merge it into
> mainline.

Ugh. It's also very ugly.

Wouldn't something like this (TOTALLY UNTESTED!) work and do the right thing?

This seems like a natural for a Kconfig decision.

Also, does -Wimplicit-fallthrough=5 work with clang too? That would
simplify things a bit, and then we could just use a regular boolean
and do

  KBUILD_CFLAGS-$(CC_IMPLICIT_FALLTHROUGH) += -Wimplicit-fallthrough=5

in the Makefile, which is more in like with what we do for other
config-time cflags..


View attachment "patch.diff" of type "text/x-patch" (1537 bytes)

Powered by blists - more mailing lists