linux-hardening - Re: [PATCH] intersil: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5d8c214b5df75b5b77450d71c7aec9f3bd97a67.camel@sipsolutions.net>
Date:   Thu, 18 Nov 2021 20:46:11 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Kees Cook <keescook@...omium.org>, Jouni Malinen <j@...fi>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Allen Pais <allen.lkml@...il.com>,
        Romain Perier <romain.perier@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] intersil: Use struct_group() for memcpy() region

On Thu, 2021-11-18 at 10:41 -0800, Kees Cook wrote:
> 
>  	/* 802.11 */
> -	__le16 frame_control; /* parts not used */
> -	__le16 duration_id;
> -	u8 addr1[ETH_ALEN];
> -	u8 addr2[ETH_ALEN]; /* filled by firmware */
> -	u8 addr3[ETH_ALEN];
> -	__le16 seq_ctrl; /* filled by firmware */
> +	struct_group(frame,

Arguably, that should be 'header' rather than 'frame' :)

johannes