linux-hardening - Re: [PATCH] ARM: socfpga: Fix crash with CONFIG_FORTIRY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hsfvtkjoh.wl-tiwai@suse.de>
Date:   Thu, 18 Nov 2021 08:27:26 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Kees Cook <keescook@...omium.org>
Cc:     Takashi Iwai <tiwai@...e.de>, Dinh Nguyen <dinguyen@...nel.org>,
        "Ivan T . Ivanov" <iivanov@...e.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE

On Wed, 17 Nov 2021 23:01:50 +0100,
Kees Cook wrote:
> 
> On Wed, Nov 17, 2021 at 08:32:44PM +0100, Takashi Iwai wrote:
> > When CONFIG_FORTIFY_SOURCE is set, memcpy() checks the potential
> > buffer overflow and panics.  The code in sofcpga bootstrapping
> > contains the memcpy() calls are mistakenly translated as the shorter
> > size, hence it triggers a panic as if it were overflowing.
> > 
> > This patch adds the __NO_FORTIFY define for avoiding the
> > false-positive crash.
> > 
> > Buglink: https://bugzilla.suse.com/show_bug.cgi?id=1192473
> > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> > ---
> > 
> > I took an easier path for now, as the attempt with a foced cast
> > failed.  If there is a better way to handle, let me know, I'd happily
> > resubmit.  Thanks!
> > 
> 
> The way these have been fixed in the past is to declare these as char
> arrays (see include/asm-generic/sections.h). I'd prefer something like
> this (totally untested):
(snip)

That looks better, indeed.  I'll rebuild the kernel with it and ask
the bug reporter for testing it.


Thanks!

Takashi