linux-hardening - Re: [PATCH] bnx2x: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Nov 2021 11:50:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Kees Cook <keescook@...omium.org>
Cc:     aelior@...vell.com, pkushwaha@...vell.com, skalluru@...vell.com,
        davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        GR-everest-linux-l2@...vell.com, netdev@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] bnx2x: Use struct_group() for memcpy() region

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@...emloft.net>:

On Thu, 18 Nov 2021 10:42:53 -0800 you wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
> 
> Use struct_group() in struct nig_stats around members egress_mac_pkt0_lo,
> egress_mac_pkt0_hi, egress_mac_pkt1_lo, and egress_mac_pkt1_hi (and the
> respective members in struct bnx2x_eth_stats), so they can be referenced
> together. This will allow memcpy() and sizeof() to more easily reason
> about sizes, improve readability, and avoid future warnings about writing
> beyond the end of struct bnx2x_eth_stats's rx_stat_ifhcinbadoctets_hi.
> 
> [...]

Here is the summary with links:
  - bnx2x: Use struct_group() for memcpy() region
    https://git.kernel.org/netdev/net-next/c/29fd0ec65e91

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html