lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 18 Nov 2021 23:13:55 -0800
From:   Jakub Kicinski <>
To:     Kees Cook <>
Cc:     "Jason A. Donenfeld" <>,
        "Gustavo A . R . Silva" <>,
        "David S. Miller" <>,
        Jonathan Lemon <>,
        Alexander Lobakin <>,
        Jakub Sitnicki <>,
        Marco Elver <>,
        Willem de Bruijn <>,
        Eric Dumazet <>,
        Cong Wang <>,
        Paolo Abeni <>,
        Talal Ahmad <>,
        Kevin Hao <>,
        Ilias Apalodimas <>,
        Kumar Kartikeya Dwivedi <>,
        Vasily Averin <>,,,,
Subject: Re: [PATCH] skbuff: Switch structure bounds to struct_group()

On Thu, 18 Nov 2021 10:36:15 -0800 Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
> Replace the existing empty member position markers "headers_start" and
> "headers_end" with a struct_group(). This will allow memcpy() and sizeof()
> to more easily reason about sizes, and improve readability.
> "pahole" shows no size nor member offset changes to struct sk_buff.
> "objdump -d" shows no object code changes (outside of WARNs affected by
> source line number changes).

This adds ~27k of these warnings to W=1 gcc builds:

include/linux/skbuff.h:851:1: warning: directive in macro's argument list

Powered by blists - more mailing lists