lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Nov 2021 15:27:57 +0100 From: Christian Brauner <christian.brauner@...ntu.com> To: Kees Cook <keescook@...omium.org> Cc: Zhen Lei <thunder.leizhen@...wei.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH] hfsplus: Use struct_group_attr() for memcpy() region On Fri, Nov 19, 2021 at 11:28:51AM -0800, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add struct_group() to mark the "info" region (containing struct DInfo > and struct DXInfo structs) in struct hfsplus_cat_folder and struct > hfsplus_cat_file that are written into directly, so the compiler can > correctly reason about the expected size of the writes. > > "pahole" shows no size nor member offset changes to struct > hfsplus_cat_folder nor struct hfsplus_cat_file. "objdump -d" shows no > object code changes. > > Signed-off-by: Kees Cook <keescook@...omium.org> > --- Looks good. Acked-by: Christian Brauner <christian.brauner@...ntu.com>
Powered by blists - more mailing lists