lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Nov 2021 14:33:38 +0100 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Kees Cook <keescook@...omium.org> Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Zhang Rui <rui.zhang@...el.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Amit Kucheria <amitk@...nel.org>, Linux PM <linux-pm@...r.kernel.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andrew Morton <akpm@...ux-foundation.org>, "open list:NETWORKING DRIVERS (WIRELESS)" <linux-wireless@...r.kernel.org>, netdev <netdev@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org>, linux-staging@...ts.linux.dev, linux-block@...r.kernel.org, linux-kbuild@...r.kernel.org, clang-built-linux@...glegroups.com, Rasmus Villemoes <linux@...musvillemoes.dk>, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2 12/63] thermal: intel: int340x_thermal: Use struct_group() for memcpy() region On Wed, Nov 24, 2021 at 12:53 AM Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com> wrote: > > On Tue, 2021-11-23 at 14:19 +0100, Rafael J. Wysocki wrote: > > On Wed, Aug 18, 2021 at 8:08 AM Kees Cook <keescook@...omium.org> > > wrote: > > > > > > In preparation for FORTIFY_SOURCE performing compile-time and run- > > > time > > > field bounds checking for memcpy(), avoid intentionally writing > > > across > > > neighboring fields. > > > > > > Use struct_group() in struct art around members weight, and ac[0- > > > 9]_max, > > > so they can be referenced together. This will allow memcpy() and > > > sizeof() > > > to more easily reason about sizes, improve readability, and avoid > > > future > > > warnings about writing beyond the end of weight. > > > > > > "pahole" shows no size nor member offset changes to struct art. > > > "objdump -d" shows no meaningful object code changes (i.e. only > > > source > > > line number induced differences). > > > > > > Cc: Zhang Rui <rui.zhang@...el.com> > > > Cc: Daniel Lezcano <daniel.lezcano@...aro.org> > > > Cc: Amit Kucheria <amitk@...nel.org> > > > Cc: linux-pm@...r.kernel.org > > > Signed-off-by: Kees Cook <keescook@...omium.org> > > > > Rui, Srinivas, any comments here? > Looks good. > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com> Applied as 5.17 material, thank you!
Powered by blists - more mailing lists