linux-hardening - Re: [PATCH v2] RDMA/mlx5: Use memset_after() to zero struct mlx5_ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbByJSkBgLRp5S8V@unreal>
Date:   Wed, 8 Dec 2021 10:51:49 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] RDMA/mlx5: Use memset_after() to zero struct
 mlx5_ib_mr

On Tue, Dec 07, 2021 at 01:20:22PM -0800, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memset(), avoid intentionally writing across
> neighboring fields.
> 
> Use memset_after() to zero the end of struct mlx5_ib_mr that should
> be initialized.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> v2: rebased, umem moved into the union and is expected to be wiped
>     https://lore.kernel.org/lkml/20211207194525.GL6385@nvidia.com
> ---
>  drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Thanks,
Acked-by: Leon Romanovsky <leonro@...dia.com>