linux-hardening - Re: [PATCH] rtc: Move variable into switch case statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164134112610.1688528.1741157654038532644.b4-ty@bootlin.com>
Date:   Wed,  5 Jan 2022 01:05:34 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Kees Cook <keescook@...omium.org>,
        Alessandro Zummo <a.zummo@...ertech.it>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH] rtc: Move variable into switch case statement

On Wed, 8 Dec 2021 20:39:15 -0800, Kees Cook wrote:
> When building with automatic stack variable initialization, GCC 12
> complains about variables defined outside of switch case statements.
> Move the variable into the case that uses it, which silences the warning:
> 
> drivers/rtc/dev.c: In function 'rtc_dev_ioctl':
> drivers/rtc/dev.c:394:30: warning: statement will never be executed [-Wswitch-unreachable]
>   394 |                         long offset;
>       |                              ^~~~~~
> 
> [...]

Applied, thanks!

[1/1] rtc: Move variable into switch case statement
      commit: ba52eac083e1598e748811ff58d259f77e4c5c4d

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@...tlin.com>