lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Jan 2022 09:24:59 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: "Gustavo A. R. Silva" <gustavoars@...nel.org>, Jon Mason <jdmason@...zu.us>, Dave Jiang <dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com> Cc: linux-ntb@...glegroups.com, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH][next] NTB/msi: Use struct_size() helper in devm_kzalloc() On 2022-01-20 4:02 p.m., Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version, > in order to avoid any potential type mistakes or integer overflows that, > in the worst scenario, could lead to heap overflows. > > Also, address the following sparse warnings: > drivers/ntb/msi.c:46:23: warning: using sizeof on a flexible structure > > Link: https://github.com/KSPP/linux/issues/174 > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> Thanks, looks good to me. Reviewed-by: Logan Gunthorpe <logang@...tatee.com>
Powered by blists - more mailing lists