lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 22 Jan 2022 16:56:49 +0000
From:   Jonathan Cameron <>
To:     Kees Cook <>
Cc:     "Gustavo A. R. Silva" <>,
        Lars-Peter Clausen <>,,,
Subject: Re: [PATCH][next] iio: hw_consumer: Use struct_size() helper in

On Thu, 20 Jan 2022 15:33:14 -0800
Kees Cook <> wrote:

> On Thu, Jan 20, 2022 at 04:52:43PM -0600, Gustavo A. R. Silva wrote:
> > Make use of the struct_size() helper instead of an open-coded version,
> > in order to avoid any potential type mistakes or integer overflows that,
> > in the worst scenario, could lead to heap overflows.
> > 
> > Also, address the following sparse warnings:
> > drivers/iio/buffer/industrialio-hw-consumer.c:63:23: warning: using sizeof on a flexible structure
> > 
> > Link:
> > Signed-off-by: Gustavo A. R. Silva <>  
> Looks good to me.
> Reviewed-by: Kees Cook <>
Good thing to tidy up, but I'm a little curious why I'm not
seeing these reports with latest sparse?
Ah. Found it via the report linked

Probably worth mentioned that in the patch descriptions. I've added it
to this one. 

I'm still setting the sparse report even with this patch.

What am I missing?


Powered by blists - more mailing lists