linux-hardening - Re: [PATCH][next] net: mana: Use struct_size() helper in mana_gd_create_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220125095933.79ba895c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 25 Jan 2022 09:59:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH][next] net: mana: Use struct_size() helper in
 mana_gd_create_dma_region()

On Mon, 24 Jan 2022 21:47:38 +0000 Dexuan Cui wrote:
> > From: Gustavo A. R. Silva <gustavoars@...nel.org>
> > Sent: Monday, January 24, 2022 1:44 PM
> >  ...
> > Make use of the struct_size() helper instead of an open-coded version,
> > in order to avoid any potential type mistakes or integer overflows that,
> > in the worst scenario, could lead to heap overflows.
> > 
> > Also, address the following sparse warnings:
> > drivers/net/ethernet/microsoft/mana/gdma_main.c:677:24: warning: using
> > sizeof on a flexible structure
> >  ...
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>  
> 
> Reviewed-by: Dexuan Cui <decui@...rosoft.com>

Thanks! Applied to net-next, 10cdc794dae8 ("net: mana: Use
struct_size() helper in mana_gd_create_dma_region()")