lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 26 Jan 2022 13:54:04 +0300
From:   Dan Carpenter <>
To:     Kees Cook <>
Cc:     "Gustavo A. R. Silva" <>,
        Viresh Kumar <>,
        Johan Hovold <>, Alex Elder <>,
        Greg Kroah-Hartman <>,,,,
Subject: Re: [PATCH][next] staging: greybus: i2c: Use struct_size() helper in

On Mon, Jan 24, 2022 at 12:19:03PM -0800, Kees Cook wrote:
> This could still overflow if struct_size() returns SIZE_MAX. Perhaps:
> 	if (check_add_overflow(struct_size(request, ops, msg_count),
> 			       data_out_size, &request_size))
> 		request_size = SIZE_MAX;
> I should brush off the saturating arithmetic helpers series:

Yes, please!  Those seem like a million times easier to use.

dan carpenter

Powered by blists - more mailing lists