linux-hardening - Re: [PATCH] elf: Relax assumptions about vaddr ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 16:44:44 +0100
From:   Magnus Groß <magnus.gross@...h-aachen.de>
To:     Alexey Dobriyan <adobriyan@...il.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Eric Biederman <ebiederm@...ssion.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH] elf: Relax assumptions about vaddr ordering

Am Wed, Feb 02, 2022 at 06:15:58PM +0300 schrieb Alexey Dobriyan:
> On Tue, Feb 01, 2022 at 02:48:16PM -0800, Andrew Morton wrote:
> > On Fri, 28 Jan 2022 14:30:12 -0800 Kees Cook <keescook@...omium.org> wrote:
> > 
> > > Andrew, can you update elf-fix-overflow-in-total-mapping-size-calculation.patch
> > > to include:
> > > 
> > > Fixes: 5f501d555653 ("binfmt_elf: reintroduce using MAP_FIXED_NOREPLACE")
> > > Cc: stable@...r.kernel.org
> > > Acked-by: Kees Cook <keescook@...omium.org>
> > 
> > Done.
> > 
> > I'm taking it that we can omit this patch ("elf: Relax assumptions
> > about vaddr ordering") and that Alexey's "ELF: fix overflow in total
> > mapping size calculation" will suffice?
> 
> Yes, it is same patch conceptually.
> It should work, but those who can't play Bioshock are better test it.

Yes it works.

Although the change from unsigned int to int is not necessary in the
first place, as you can avoid the -1 initialization for min_addr by
simply using ULONG_MAX, as can be seen in my patch.