lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 3 Feb 2022 09:13:30 +0100
From:   Geert Uytterhoeven <>
To:     Kees Cook <>
Cc:     Greg Ungerer <>,
        Mark Rutland <>,
        "Peter Zijlstra (Intel)" <>,
        Arnd Bergmann <>,
        Linux Kernel Mailing List <>,
        linux-m68k <>,
Subject: Re: [PATCH] m68k: cmpxchg: Dereference matching size

Hi Kees,

On Wed, Feb 2, 2022 at 11:53 PM Kees Cook <> wrote:
> Similar to the recent arm64 fix[1], avoid overly wide casts in the cmpxchg
> implementation. Avoid this warning under -Warray-bounds with GCC 11:
> net/sched/cls_tcindex.c: In function 'tcindex_set_parms':
> ./arch/m68k/include/asm/cmpxchg.h:64:17: warning: array subscript 'volatile struct __xchg_dummy[0]' is partly outside array bounds of 'struct tcf_result[1]' [-Warray-bounds]
>    64 |                 __asm__ __volatile__
>       |                 ^~~~~~~
> net/sched/cls_tcindex.c:338:27: note: while referencing 'cr'
>   338 |         struct tcf_result cr = {};
>       |                           ^~
> No binary output differences are seen from this change.
> [1] commit 3364c6ce23c6 ("arm64: atomics: lse: Dereference matching size")
> Signed-off-by: Kees Cook <>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <>

Do you want me to queue this in the m68k for-v5.18 branch, or do
you want to take it yourself, together with commit a8712a32665f9b1a
("Makefile: Enable -Warray-bounds") in linux-next that triggers this?
In case of the latter:
Acked-by: Geert Uytterhoeven <>

Please let me know. Thanks!



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists