lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 14 Feb 2022 11:20:10 +0000
To:     Kees Cook <>
Subject: Re: [PATCH] etherdevice: Adjust ether_addr* prototypes to silence


This patch was applied to netdev/net-next.git (master)
by David S. Miller <>:

On Sat, 12 Feb 2022 09:14:49 -0800 you wrote:
> With GCC 12, -Wstringop-overread was warning about an implicit cast from
> char[6] to char[8]. However, the extra 2 bytes are always thrown away,
> alignment doesn't matter, and the risk of hitting the edge of unallocated
> memory has been accepted, so this prototype can just be converted to a
> regular char *. Silences:
> net/core/dev.c: In function ‘bpf_prog_run_generic_xdp’: net/core/dev.c:4618:21: warning: ‘ether_addr_equal_64bits’ reading 8 bytes from a region of size 6 [-Wstringop-overread]
>  4618 |         orig_host = ether_addr_equal_64bits(eth->h_dest, > skb->dev->dev_addr);
>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/core/dev.c:4618:21: note: referencing argument 1 of type ‘const u8[8]’ {aka ‘const unsigned char[8]’}
> net/core/dev.c:4618:21: note: referencing argument 2 of type ‘const u8[8]’ {aka ‘const unsigned char[8]’}
> In file included from net/core/dev.c:91: include/linux/etherdevice.h:375:20: note: in a call to function ‘ether_addr_equal_64bits’
>   375 | static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
>       |                    ^~~~~~~~~~~~~~~~~~~~~~~
> [...]

Here is the summary with links:
  - etherdevice: Adjust ether_addr* prototypes to silence -Wstringop-overead

You are awesome, thank you!
Deet-doot-dot, I am a bot.

Powered by blists - more mailing lists