lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Feb 2022 10:24:44 -0700 From: Shuah Khan <skhan@...uxfoundation.org> To: Kees Cook <keescook@...omium.org>, Daniel Latypov <dlatypov@...gle.com> Cc: David Gow <davidgow@...gle.com>, Vitor Massaru Iha <vitor@...saru.org>, Rasmus Villemoes <linux@...musvillemoes.dk>, Nick Desaulniers <ndesaulniers@...gle.com>, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org, KUnit Development <kunit-dev@...glegroups.com>, linux-kselftest@...r.kernel.org, linux-hardening@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH] lib: overflow: Convert to Kunit On 2/17/22 10:09 AM, Kees Cook wrote: > On Wed, Feb 16, 2022 at 02:57:12PM -0800, Daniel Latypov wrote: >> On Wed, Feb 16, 2022 at 2:42 PM Kees Cook <keescook@...omium.org> wrote: >>> >>> Convert overflow unit tests to KUnit, for better integration into the >>> kernel self test framework. Includes a rename of test_overflow.c to >>> overflow_kunit.c, and CONFIG_TEST_OVERFLOW to CONFIG_OVERFLOW_KUNIT_TEST. >>> >>> $ ./tools/testing/kunit/kunit.py config >>> ... >>> $ ./tools/testing/kunit/kunit.py run overflow >> >> JFYI, you can run this as a one-liner via >> >> $ ./tools/testing/kunit/kunit.py run --kunitconfig /dev/stdin <<EOF >> CONFIG_KUNIT=y >> CONFIG_TEST_OVERFLOW=y >> EOF >> >> The above is taken from my own duplicate version of this patch >> [1] https://lore.kernel.org/linux-kselftest/20210503211536.1384578-1-dlatypov@google.com/ > > Ah-ha! I thought I remembered this conversion being proposed before but > I totally failed to find it. Thank you! I'll compare/adjust this patch > and add you as Co-developed-by. > >>> ... >>> [14:33:51] Starting KUnit Kernel (1/1)... >>> [14:33:51] ============================================================ >>> [14:33:51] ================== overflow (11 subtests) ================== >>> [14:33:51] [PASSED] u8_overflow_test >>> [14:33:51] [PASSED] s8_overflow_test >>> [14:33:51] [PASSED] u16_overflow_test >>> [14:33:51] [PASSED] s16_overflow_test >>> [14:33:51] [PASSED] u32_overflow_test >>> [14:33:51] [PASSED] s32_overflow_test >>> [14:33:51] [PASSED] u64_overflow_test >>> [14:33:51] [PASSED] s64_overflow_test >>> [14:33:51] [PASSED] overflow_shift_test >>> [14:33:51] [PASSED] overflow_allocation_test >>> [14:33:51] [PASSED] overflow_size_helpers_test >>> [14:33:51] ==================== [PASSED] overflow ===================== >>> [14:33:51] ============================================================ >>> [14:33:51] Testing complete. Passed: 11, Failed: 0, Crashed: 0, Skipped: 0, Errors: 0 >>> [14:33:51] Elapsed time: 12.525s total, 0.001s configuring, 12.402s building, 0.101s running >>> >>> Cc: David Gow <davidgow@...gle.com> >>> Cc: Vitor Massaru Iha <vitor@...saru.org> >>> Cc: Rasmus Villemoes <linux@...musvillemoes.dk> >>> Cc: Nick Desaulniers <ndesaulniers@...gle.com> >>> Co-developed-by: Vitor Massaru Iha <vitor@...saru.org> >>> Signed-off-by: Vitor Massaru Iha <vitor@...saru.org> >>> Link: https://lore.kernel.org/lkml/20200720224418.200495-1-vitor@massaru.org/ >>> Signed-off-by: Kees Cook <keescook@...omium.org> >> >> Reviewed-by: Daniel Latypov <dlatypov@...gle.com> >> Looks good to me. I recall reviewing this when Vitor was working on this. Glad to this happen. Reviewed-by: Shuah Khan <skhan@...uxfoundation.org> thanks, -- Shuah
Powered by blists - more mailing lists