lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Feb 2022 21:47:19 +0100 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Dan Li <ashimida@...ux.alibaba.com> Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Kees Cook <keescook@...omium.org>, Masahiro Yamada <masahiroy@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org>, Mark Rutland <mark.rutland@....com>, Sami Tolvanen <samitolvanen@...gle.com>, Nicholas Piggin <npiggin@...il.com>, Guenter Roeck <linux@...ck-us.net>, Masami Hiramatsu <mhiramat@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, Luc Van Oostenryck <luc.vanoostenryck@...il.com>, Marco Elver <elver@...gle.com>, linux-kernel <linux-kernel@...r.kernel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, llvm@...ts.linux.dev, linux-hardening@...r.kernel.org Subject: Re: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support On Fri, Feb 25, 2022 at 4:24 AM Dan Li <ashimida@...ux.alibaba.com> wrote: > > + - Clang (https://clang.llvm.org/docs/ShadowCallStack.html) > + - GCC (https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#Instrumentation-Options) Maybe Clang: and GCC: instead of the parenthesis? > +#ifdef CONFIG_SHADOW_CALL_STACK > +#define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) > +#endif Since both compilers have it, and I guess the `#ifdef` condition would work for both, could this be moved into `compiler_types.h` where the empty `__noscs` definition is, and remove the one from `compiler-clang.h`? Cheers, Miguel
Powered by blists - more mailing lists