linux-hardening - RE: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 15:16:22 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Miguel Ojeda' <miguel.ojeda.sandonis@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>
CC:     Dan Li <ashimida@...ux.alibaba.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mark Rutland <mark.rutland@....com>,
        "Sami Tolvanen" <samitolvanen@...gle.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Miguel Ojeda <ojeda@...nel.org>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Marco Elver <elver@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: RE: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support

From: Miguel Ojeda
> Sent: 01 March 2022 09:29
> 
> On Mon, Feb 28, 2022 at 11:35 PM Nick Desaulniers
> <ndesaulniers@...gle.com> wrote:
> >
> > Or simply add a #define for __noscs to include/linux/compiler-gcc.h
> > with appropriate guard and leave the existing #ifndef in
> > include/linux/compiler_types.h as is.  I'd prefer that when the
> > compilers differ in terms of feature detection since it's as explicit
> > as possible.
> 
> The idea is to avoid differing here to begin with, i.e. to use the
> same code for both compilers (only whenever that is possible, of
> course), thus having a single `#define` in a single file.
> 
> Do you think we will have to change in the future for some reason,
> thus needing to split it again?

What happens if an out of tree module is compiled with the other compiler?
Surely this is part of the ABI and should be defined for the architecture?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)