linux-hardening - Re: [PATCH] ARM: vexpress/spc: Avoid negative array index when !SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkbUyzzgsaBwyB+3@e110455-lin.cambridge.arm.com>
Date:   Fri, 1 Apr 2022 11:32:43 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     Kees Cook <keescook@...omium.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ARM: vexpress/spc: Avoid negative array index when !SMP

On Fri, Apr 01, 2022 at 11:11:47AM +0100, Sudeep Holla wrote:
> On Fri, Apr 01, 2022 at 10:28:29AM +0100, Liviu Dudau wrote:
> > On Thu, Mar 31, 2022 at 12:04:43PM -0700, Kees Cook wrote:
> > > When building multi_v7_defconfig+CONFIG_SMP=n, -Warray-bounds exposes
> > > a couple negative array index accesses:
> > > 
> > > arch/arm/mach-vexpress/spc.c: In function 've_spc_clk_init':
> > > arch/arm/mach-vexpress/spc.c:583:21: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds]
> > >   583 |   if (init_opp_table[cluster])
> > >       |       ~~~~~~~~~~~~~~^~~~~~~~~
> > > arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table'
> > >   556 |  bool init_opp_table[MAX_CLUSTERS] = { false };
> > >       |       ^~~~~~~~~~~~~~
> > > arch/arm/mach-vexpress/spc.c:592:18: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds]
> > >   592 |    init_opp_table[cluster] = true;
> > >       |    ~~~~~~~~~~~~~~^~~~~~~~~
> > > arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table'
> > >   556 |  bool init_opp_table[MAX_CLUSTERS] = { false };
> > >       |       ^~~~~~~~~~~~~~
> > > 
> > > Skip this logic when built !SMP.
> > > 
> > > Cc: Liviu Dudau <liviu.dudau@....com>
> > > Cc: Sudeep Holla <sudeep.holla@....com>
> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> > > Cc: Russell King <linux@...linux.org.uk>
> > > Cc: linux-arm-kernel@...ts.infradead.org
> > > Signed-off-by: Kees Cook <keescook@...omium.org>
> > 
> > Acked-by: Liviu Dudau <liviu.dudau@....com>
> > 
> > Sudeep, can you please take this through your tree for sending it to arm-soc?
> >
> 
> Sure, I will do that as soon as -rc1 is out.

Cheers, much appreciated!

Best regards,
Liviu

> 
> -- 
> Regards,
> Sudeep

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯