linux-hardening - Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Apr 2022 09:48:58 -0700
From:   Allen Pais <apais@...ux.microsoft.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     olivier.dautricourt@...lia.com, sr@...x.de, vkoul@...nel.org,
        linux-hardening@...r.kernel.org, ludovic.desroches@...rochip.com,
        tudor.ambarus@...rochip.com, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, nsaenz@...nel.org,
        paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com,
        gustavo.pimentel@...opsys.com, vireshk@...nel.org,
        andriy.shevchenko@...ux.intel.com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, afaerber@...e.de, mani@...nel.org,
        logang@...tatee.com, sanju.mehta@....com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        agross@...nel.org, bjorn.andersson@...aro.org,
        krzysztof.kozlowski@...aro.org, green.wan@...ive.com,
        orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org,
        wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue


>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
>> 
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
> 
> Thanks for working on this! Can you describe the process for the
> replacement? For example, was it a 1:1 replacement from one set of
> functions to another, or something more nuanced? Did you do this by hand,
> or with the help of something like Coccinelle?

 For this series, I did the work manually as certain had the potential to be improved.
Also, there are drivers which use queue_work() instead of schedule_work(). 

> Including these details will help maintainers with review, and will help
> others do other conversions in the future.
> 

 I will wait for a couple of more days and send out the rest of the series with
More details.

Thanks.

> Thanks!
> 
> -Kees
> 
> -- 
> Kees Cook