linux-hardening - Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8cb3d63-f5b9-d067-af66-86f7a7c7f76c@intel.com>
Date:   Wed, 27 Apr 2022 08:20:11 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Vinod Koul <vkoul@...nel.org>,
        Allen Pais <apais@...ux.microsoft.com>
Cc:     olivier.dautricourt@...lia.com, sr@...x.de, keescook@...omium.org,
        linux-hardening@...r.kernel.org, ludovic.desroches@...rochip.com,
        tudor.ambarus@...rochip.com, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, nsaenz@...nel.org,
        paul@...pouillou.net, Eugeniy.Paltsev@...opsys.com,
        gustavo.pimentel@...opsys.com, vireshk@...nel.org,
        andriy.shevchenko@...ux.intel.com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, afaerber@...e.de, mani@...nel.org,
        logang@...tatee.com, sanju.mehta@....com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        agross@...nel.org, bjorn.andersson@...aro.org,
        krzysztof.kozlowski@...aro.org, green.wan@...ive.com,
        orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org,
        wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue


On 4/26/2022 7:45 PM, Vinod Koul wrote:
> On 19-04-22, 21:16, Allen Pais wrote:
>> The tasklet is an old API which will be deprecated, workqueue API
>> cab be used instead of them.
> What is the reason for tasklet removal, I am not sure old is a reason to
> remove an API...
>
>> This patch replaces the tasklet usage in drivers/dma/* with a
>> simple work.
> Dmaengines need very high throughput, one of the reasons in dmaengine
> API design to use tasklet was higher priority given to them. Will the
> workqueue allow that...?

Wouldn't the logical move be to convert threaded irq IF tasklets are 
being deprecated rather than using workqueue as replacement?

Also, wouldn't all the spin_lock_bh() calls need to be changed to 
spin_lock_irqsave() now? Probably not as simple as just replace tasklet 
with workqueue.