lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 May 2022 11:27:26 -0700 From: Daniel Latypov <dlatypov@...gle.com> To: Kees Cook <keescook@...omium.org> Cc: Nick Desaulniers <ndesaulniers@...gle.com>, kernel test robot <lkp@...el.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Vitor Massaru Iha <vitor@...saru.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH] lib: overflow: Always build 64-bit test cases On Wed, May 11, 2022 at 10:45 AM Kees Cook <keescook@...omium.org> wrote: > > There shouldn't be a reason to not build the 64-bit test cases on 32-bit > systems; the types exist there too. Remove the #ifdefs. > > Reported-by: kernel test robot <lkp@...el.com> > Link: https://lore.kernel.org/lkml/202205110324.7GrtxG8u-lkp@intel.com > Fixes: 455a35a6cdb6 ("lib: add runtime test of check_*_overflow functions") > Cc: Rasmus Villemoes <linux@...musvillemoes.dk> > Cc: Vitor Massaru Iha <vitor@...saru.org> > Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org> > Cc: Daniel Latypov <dlatypov@...gle.com> > Signed-off-by: Kees Cook <keescook@...omium.org> Tested-by: Daniel Latypov <dlatypov@...gle.com> Makes sense and looks good to me, I was able to run it via $ ./tools/testing/kunit/kunit.py run --arch=i386 --build_dir=kunit_i386/ overflow Raw output was: # u64_overflow_test: 17 u64 arithmetic tests finished ok 7 - u64_overflow_test # s64_overflow_test: 21 s64 arithmetic tests finished ok 8 - s64_overflow_test
Powered by blists - more mailing lists