lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 May 2022 11:22:17 +0900 From: Kuniyuki Iwashima <kuniyu@...zon.co.jp> To: <keescook@...omium.org> CC: <ast@...nel.org>, <cong.wang@...edance.com>, <davem@...emloft.net>, <hch@...radead.org>, <kuba@...nel.org>, <kuniyu@...zon.co.jp>, <linux-hardening@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <pabeni@...hat.com>, <viro@...iv.linux.org.uk> Subject: Re: [PATCH] af_unix: Silence randstruct GCC plugin warning From: Kees Cook <keescook@...omium.org> Date: Tue, 10 May 2022 17:01:09 -0700 > While preparing for Clang randstruct support (which duplicated many of > the warnings the randstruct GCC plugin warned about), one strange one > remained only for the randstruct GCC plugin. Eliminating this rids > the plugin of the last exception. > > It seems the plugin is happy to dereference individual members of > a cross-struct cast, but it is upset about casting to a whole object > pointer. This only manifests in one place in the kernel, so just replace > the variable with individual member accesses. There is no change in > executable instruction output. > > Drop the last exception from the randstruct GCC plugin. > > Cc: "David S. Miller" <davem@...emloft.net> > Cc: Jakub Kicinski <kuba@...nel.org> > Cc: Christoph Hellwig <hch@...radead.org> > Cc: Paolo Abeni <pabeni@...hat.com> > Cc: Kuniyuki Iwashima <kuniyu@...zon.co.jp> > Cc: Alexei Starovoitov <ast@...nel.org> > Cc: Cong Wang <cong.wang@...edance.com> > Cc: Al Viro <viro@...iv.linux.org.uk> > Cc: netdev@...r.kernel.org > Cc: linux-hardening@...r.kernel.org > Signed-off-by: Kees Cook <keescook@...omium.org> LGTM, thank you. Acked-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Powered by blists - more mailing lists