lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2022 11:57:16 -0700 From: Sami Tolvanen <samitolvanen@...gle.com> To: Kees Cook <keescook@...omium.org> Cc: linux-kernel@...r.kernel.org, Josh Poimboeuf <jpoimboe@...hat.com>, Peter Zijlstra <peterz@...radead.org>, x86@...nel.org, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Joao Moreira <joao@...rdrivepizza.com>, Sedat Dilek <sedat.dilek@...il.com>, Steven Rostedt <rostedt@...dmis.org>, linux-hardening@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, llvm@...ts.linux.dev Subject: Re: [RFC PATCH v2 20/21] x86: Add support for CONFIG_CFI_CLANG On Sat, May 14, 2022 at 3:03 PM Kees Cook <keescook@...omium.org> wrote: > > On Fri, May 13, 2022 at 01:21:58PM -0700, Sami Tolvanen wrote: > > +#ifdef CONFIG_CFI_CLANG > > +static void decode_cfi_insn(struct pt_regs *regs, unsigned long *target, > > + unsigned long *type) > > +{ > > + char buffer[MAX_INSN_SIZE]; > > + struct insn insn; > > + int offset; > > + > > + *target = *type = 0; > > Should report_cfi_failure() have some additional hinting for the case > where target/type are zero? Like, "hey, got an inexplicable CFI failure > here, but preamble decode failed. Yikes!" Good point, I'll add an error message here. Sami
Powered by blists - more mailing lists