lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 May 2022 09:47:37 +0100 From: Mark Rutland <mark.rutland@....com> To: Sami Tolvanen <samitolvanen@...gle.com> Cc: linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>, Josh Poimboeuf <jpoimboe@...hat.com>, Peter Zijlstra <peterz@...radead.org>, x86@...nel.org, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Joao Moreira <joao@...rdrivepizza.com>, Sedat Dilek <sedat.dilek@...il.com>, Steven Rostedt <rostedt@...dmis.org>, linux-hardening@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, llvm@...ts.linux.dev Subject: Re: [RFC PATCH v2 08/21] psci: Fix the function type for psci_initcall_t On Fri, May 13, 2022 at 01:21:46PM -0700, Sami Tolvanen wrote: > Functions called through a psci_initcall_t pointer all have > non-const arguments. Fix the type definition to avoid tripping > indirect call checks with CFI_CLANG. > > Reported-by: Mark Rutland <mark.rutland@....com> > Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com> I'd prefer that we spread the `const` to each of the implementations rather than dropping it from the type. I have a local patch for that I can send out shortly. Thanks, Mark. > --- > drivers/firmware/psci/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index cfb448eabdaa..6554bf4b8c99 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -521,7 +521,7 @@ static int __init psci_probe(void) > return 0; > } > > -typedef int (*psci_initcall_t)(const struct device_node *); > +typedef int (*psci_initcall_t)(struct device_node *); > > /* > * PSCI init function for PSCI versions >=0.2 > -- > 2.36.0.550.gb090851708-goog >
Powered by blists - more mailing lists