linux-hardening - Re: [PATCH v2] sign-file: Convert API usage to support OpenSSL v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202205181457.01A586D25E@keescook>
Date:   Wed, 18 May 2022 14:58:05 -0700
From:   Kees Cook <keescook@...omium.org>
To:     David Howells <dhowells@...hat.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Eric Biggers <ebiggers@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Salvatore Bonaccorso <carnil@...ian.org>,
        keyrings@...r.kernel.org, Adam Langley <agl@...gle.com>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] sign-file: Convert API usage to support OpenSSL v3

On Wed, May 18, 2022 at 02:51:29PM -0700, Kees Cook wrote:
> OpenSSL's ENGINE API is deprecated in OpenSSL v3.0, along with some
> other functions. Remove the ENGINE use and a macro work-around for
> ERR_get_error_line().
> 
> Cc: David Howells <dhowells@...hat.com>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Eric Biggers <ebiggers@...nel.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Cc: Salvatore Bonaccorso <carnil@...ian.org>
> Cc: keyrings@...r.kernel.org
> Suggested-by: Adam Langley <agl@...gle.com>
> Co-developed-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> v1: https://lore.kernel.org/lkml/20211005161833.1522737-1-lee.jones@linaro.org/
> v2: https://lore.kernel.org/lkml/Yicwb+Ceiu8JjVIS@google.com/
> v3:
>  - Eliminate all the build warnings with OpenSSL 3
>  - Fully remove ENGINE usage, if it can be optional, just drop it.
> ---
>  scripts/sign-file.c | 49 ++++++++++-----------------------------------
>  1 file changed, 11 insertions(+), 38 deletions(-)
> 
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c

Eh, this only fixes sign-file.c. Fixes are still needed for
extract-cert.c...

-- 
Kees Cook