lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 May 2022 20:40:23 -0700 From: Stephen Boyd <sboyd@...nel.org> To: Len Baker <len.baker@....com>, Michael Turquette <mturquette@...libre.com>, Tero Kristo <kristo@...nel.org> Cc: Len Baker <len.baker@....com>, Kees Cook <keescook@...omium.org>, linux-omap@...r.kernel.org, linux-clk@...r.kernel.org, linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] clk: ti: composite: Prefer kcalloc over open coded arithmetic Quoting Len Baker (2021-09-04 06:17:14) > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or similar) > function arguments due to the risk of them overflowing. This could lead > to values wrapping around and a smaller allocation being made than the > caller was expecting. Using those allocations could lead to linear > overflows of heap memory and other misbehaviors. > > So, use the purpose specific kcalloc() function instead of the argument > size * count in the kzalloc() function. > > [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > > Signed-off-by: Len Baker <len.baker@....com> > --- Applied to clk-next
Powered by blists - more mailing lists