lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 May 2022 05:15:37 +0000 From: Ming Qian <ming.qian@....com> To: Kees Cook <keescook@...omium.org> CC: Shijie Qin <shijie.qin@....com>, Eagle Zhou <eagle.zhou@....com>, Mauro Carvalho Chehab <mchehab@...nel.org>, "Gustavo A . R . Silva" <gustavoars@...nel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>, Nicolas Dufresne <nicolas.dufresne@...labora.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org> Subject: RE: [EXT] [PATCH] media: amphion: Replace zero-length array with flexible-array member > From: Kees Cook <keescook@...omium.org> > Sent: 2022年5月28日 5:30 > To: Ming Qian <ming.qian@....com> > Cc: Kees Cook <keescook@...omium.org>; Shijie Qin <shijie.qin@....com>; > Eagle Zhou <eagle.zhou@....com>; Mauro Carvalho Chehab > <mchehab@...nel.org>; Gustavo A . R . Silva <gustavoars@...nel.org>; > linux-media@...r.kernel.org; Hans Verkuil <hverkuil-cisco@...all.nl>; Nicolas > Dufresne <nicolas.dufresne@...labora.com>; linux-kernel@...r.kernel.org; > linux-hardening@...r.kernel.org > Subject: [EXT] [PATCH] media: amphion: Replace zero-length array with > flexible-array member > > Caution: EXT Email > > There is a regular need in the kernel to provide a way to declare having a > dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these cases. > The older style of one-element or zero-length arrays should no longer be > used[2][3]. > > [1] > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wiki > pedia.org%2Fwiki%2FFlexible_array_member&data=05%7C01%7Cming.q > ian%40nxp.com%7C8f4e000999114f77682908da40280bd5%7C686ea1d3bc2 > b4c6fa92cd99c5c301635%7C0%7C0%7C637892837984973240%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > wiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DjFIwJC45pAqdCP5EE > QE7n5F8GH45NdWrQoXunNEhZY%3D&reserved=0 > [2] > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ke > rnel.org%2Fdoc%2Fhtml%2Flatest%2Fprocess%2Fdeprecated.html%23zero-len > gth-and-one-element-arrays&data=05%7C01%7Cming.qian%40nxp.com% > 7C8f4e000999114f77682908da40280bd5%7C686ea1d3bc2b4c6fa92cd99c5c > 301635%7C0%7C0%7C637892837984973240%7CUnknown%7CTWFpbGZsb3 > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > 3D%7C3000%7C%7C%7C&sdata=xKvM4qigtFIfvBzNDka44uqTUfloTnNmC > xPVAhlk5tc%3D&reserved=0 > [3] > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. > com%2FKSPP%2Flinux%2Fissues%2F78&data=05%7C01%7Cming.qian%4 > 0nxp.com%7C8f4e000999114f77682908da40280bd5%7C686ea1d3bc2b4c6fa > 92cd99c5c301635%7C0%7C0%7C637892837984973240%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ > XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uzEzW1AEtyWGsmJCHJ%2F > DfMqa4lCsJjmVfz7KRugzOho%3D&reserved=0 > > Fixes: 9f599f351e86 ("media: amphion: add vpu core driver") > Cc: Ming Qian <ming.qian@....com> > Cc: Shijie Qin <shijie.qin@....com> > Cc: Zhou Peng <eagle.zhou@....com> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org> > Cc: Gustavo A. R. Silva <gustavoars@...nel.org> > Cc: linux-media@...r.kernel.org > Signed-off-by: Kees Cook <keescook@...omium.org> Reviewed-by: ming_qian <ming.qian@....com> > --- > drivers/media/platform/amphion/vpu_dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/amphion/vpu_dbg.c > b/drivers/media/platform/amphion/vpu_dbg.c > index da62bd718fb8..f72c8a506b22 100644 > --- a/drivers/media/platform/amphion/vpu_dbg.c > +++ b/drivers/media/platform/amphion/vpu_dbg.c > @@ -27,7 +27,7 @@ struct print_buf_desc { > u32 bytes; > u32 read; > u32 write; > - char buffer[0]; > + char buffer[]; > }; > > static char *vb2_stat_name[] = { > -- > 2.32.0
Powered by blists - more mailing lists