lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2022 17:11:13 +0200 From: "Jason A. Donenfeld" <Jason@...c4.com> To: Matthew Wilcox <willy@...radead.org> Cc: linux-mm@...ck.org, linux-xfs@...r.kernel.org, linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org, Uladzislau Rezki <urezki@...il.com>, Kees Cook <keescook@...omium.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Joe Perches <joe@...ches.com> Subject: Re: [PATCH] usercopy: use unsigned long instead of uintptr_t On Thu, Jun 16, 2022 at 04:51:08PM +0200, Jason A. Donenfeld wrote: > If that's a "dinosaur approach" that "has to stop", it'd certainly be > news to me (and I'm guessing others on the list too). I've never really > seen anybody question the kernel's `unsigned long` usage before. > > So hopefully some outcome of this discussion will make it clear, and > then either this patch will go in, or I'll get to work on carefully > adjusting my code that uses `unsigned long` at the moment. Searching through list archives, there's not much, but I did find [1] from Linus: PPS. And btw, the warning is unacceptable too. Cast the thing to "unsigned long" (or uintptr_t, but quite frankly, in the kernel I'd suggest "unsigned long" rather than the more obscure standard types) after you've fixed the macro argument problem. [1] https://lore.kernel.org/lkml/AANLkTineDxntR0ZTXdgXrc6qx6pATTORgOwFR5+w5MLN@mail.gmail.com/
Powered by blists - more mailing lists