lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202209021537.43D3FDD@keescook> Date: Fri, 2 Sep 2022 15:37:19 -0700 From: Kees Cook <keescook@...omium.org> To: Guenter Roeck <linux@...ck-us.net> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, Wolfram Sang <wsa+renesas@...g-engineering.com>, Nick Desaulniers <ndesaulniers@...gle.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Jonathan Corbet <corbet@....net>, Len Baker <len.baker@....com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Francis Laniel <laniel_francis@...vacyrequired.com>, Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2] string: Introduce strtomem() and strtomem_pad() On Fri, Sep 02, 2022 at 02:47:04PM -0700, Guenter Roeck wrote: > On Fri, Sep 02, 2022 at 01:52:35PM -0700, Kees Cook wrote: > > On Thu, Sep 01, 2022 at 12:34:34PM -0700, Guenter Roeck wrote: > > > On 9/1/22 12:09, Kees Cook wrote: > > > > [...] > > > > -If a caller is using non-NUL-terminated strings, strncpy() can > > > > -still be used, but destinations should be marked with the `__nonstring > > > > +If a caller is using non-NUL-terminated strings, strtomem() should be > > > > +be used, and the destinations should be marked with the `__nonstring > > > > > > s/be // > > > > Thanks! > > > > > > [...] > > > > +++ b/include/linux/fortify-string.h > > > > @@ -77,6 +77,36 @@ extern char *__underlying_strncpy(char *p, const char *q, __kernel_size_t size) > > > > #define POS __pass_object_size(1) > > > > #define POS0 __pass_object_size(0) > > > > +/** strncpy - Copy a string to memory with non-guaranteed NUL padding > > > > > > Does that need a newline before strncpy() ? > > > > What do you mean here? I think this is valid kerndoc, but I'll > > double-check. (And will continue in the neighboring htmldoc build thread.) > > > > Just asking. "/** strncpy - Copy a string ..." seemed unusual without > newline between "/**" and the function name. Oops, yes. Thank you again! -- Kees Cook
Powered by blists - more mailing lists