lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202209022215.FA016FA6@keescook> Date: Fri, 2 Sep 2022 22:17:26 -0700 From: Kees Cook <keescook@...omium.org> To: David Gow <davidgow@...gle.com> Cc: Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>, Nick Desaulniers <ndesaulniers@...gle.com>, Nathan Chancellor <nathan@...nel.org>, Tom Rix <trix@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Vlastimil Babka <vbabka@...e.cz>, "Steven Rostedt (Google)" <rostedt@...dmis.org>, Yury Norov <yury.norov@...il.com>, Masami Hiramatsu <mhiramat@...nel.org>, Sander Vanheule <sander@...nheule.net>, linux-hardening@...r.kernel.org, llvm@...ts.linux.dev, Peter Zijlstra <peterz@...radead.org>, Josh Poimboeuf <jpoimboe@...nel.org>, Dan Williams <dan.j.williams@...el.com>, Isabella Basso <isabbasso@...eup.net>, Eric Dumazet <edumazet@...gle.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Eric Biggers <ebiggers@...gle.com>, Hannes Reinecke <hare@...e.de>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 2/3] fortify: Add KUnit test for FORTIFY_SOURCE internals On Sat, Sep 03, 2022 at 10:59:24AM +0800, David Gow wrote: > On Sat, Sep 3, 2022 at 4:43 AM Kees Cook <keescook@...omium.org> wrote: > > > > Add lib/fortify_kunit.c KUnit test for checking the expected behavioral > > characteristics of FORTIFY_SOURCE internals. > > [...] > > Overall, this looks good. It's a bit of a shame FORTIFY_SOURCE doesn't > work under UML, but I tested it on everything else I had to hand and > it looked good. It looks like this was never picked up: https://lore.kernel.org/lkml/20220210003224.773957-1-keescook@chromium.org/ I suppose I could take it via the kernel hardening tree? > One tiny typo in a comment below, but otherwise this is: > > Reviewed-by: David Gow <davidgow@...gle.com> > > [...] > > +/* > > + * Runtime test cases for CONFIG_FORTIFY_SOURCE that aren't expected to > > + * Oops th kernel on success. (For those, see drivers/misc/lkdtm/fortify.c) > > Nit: Oops _the_ kernel Thanks! I'll get that updated. :) -- Kees Cook
Powered by blists - more mailing lists