lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 23 Sep 2022 23:06:19 -0700
From:   Kees Cook <>
To:     "Gustavo A. R. Silva" <>
Cc:     HighPoint Linux Team <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,,,
Subject: Re: [PATCH 2/2][next] scsi: hptiop: Use struct_size() helper in code
 related to struct hpt_iop_request_scsi_command

On Thu, Sep 22, 2022 at 11:55:33AM -0500, Gustavo A. R. Silva wrote:
> Prefer struct_size() over open-coded versions of idiom:
> sizeof(struct-with-flex-array) + sizeof(typeof-flex-array-elements) * count
> where count is the max number of items the flexible array is supposed to
> contain.
> Link:
> Signed-off-by: Gustavo A. R. Silva <>

Looks correct; thanks!

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists