lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YzDoj5E/WsswW0OH@thelio-3990X> Date: Sun, 25 Sep 2022 16:47:27 -0700 From: Nathan Chancellor <nathan@...nel.org> To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> Cc: Kees Cook <keescook@...omium.org>, Miguel Ojeda <ojeda@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, llvm@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2] Compiler Attributes: Introduce __access_*() function attribute On Sun, Sep 25, 2022 at 01:36:22PM +0200, Miguel Ojeda wrote: > On Sun, Sep 25, 2022 at 6:46 AM Nathan Chancellor <nathan@...nel.org> wrote: > > > > The GCC docs say it is 'access', instead of '__access__'. I assume it is > > probably okay so: > > Yeah, attributes can be used either with or without double > underscores, see > https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Attribute-Syntax. Aha, I figured I was missing something. That is what I get for doing a mobile review :) > In this file, we always use the underscore ones to minimize the chance > of collisions, since the idea is that the rest of the kernel uses the > shorthands provided here. That certainly makes sense, I think it is a little easier to read too, as it gives the attribute name a little separating from '__attribute__' and any arguments to it. Cheers, Nathan
Powered by blists - more mailing lists