lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 26 Sep 2022 18:39:53 +0300
From:   Gwan-gyeong Mun <>
Subject: [PATCH v12 9/9] drm/i915: Remove truncation warning for large objects

From: Chris Wilson <>

Having addressed the issues surrounding incorrect types for local
variables and potential integer truncation in using the scatterlist API,
we have closed all the loop holes we had previously identified with
dangerously large object creation. As such, we can eliminate the warning
put in place to remind us to complete the review.

Signed-off-by: Chris Wilson <>
Signed-off-by: Gwan-gyeong Mun <>
Cc: Tvrtko Ursulin <>
Cc: Brian Welty <>
Cc: Matthew Auld <>
Cc: Thomas Hellström <>
Testcase: igt@..._create@...ate-massive
Reviewed-by: Nirmoy Das <>
Reviewed-by: Mauro Carvalho Chehab <>
Reviewed-by: Andrzej Hajda <>
 drivers/gpu/drm/i915/gem/i915_gem_object.h | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
index a826b959e3fb..7dc784079c6c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
@@ -20,25 +20,10 @@
 enum intel_region_id;
- * XXX: There is a prevalence of the assumption that we fit the
- * object's page count inside a 32bit _signed_ variable. Let's document
- * this and catch if we ever need to fix it. In the meantime, if you do
- * spot such a local variable, please consider fixing!
- *
- * We can check for invalidly typed locals with typecheck(), see for example
- * i915_gem_object_get_sg().
- */
 static inline bool i915_gem_object_size_2big(u64 size)
 	struct drm_i915_gem_object *obj;
-		return true;
 	if (overflows_type(size, obj->base.size))
 		return true;

Powered by blists - more mailing lists