lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 4 Oct 2022 20:06:41 -0700
From:   Kees Cook <>
To:     "Gustavo A. R. Silva" <>
Cc:     Steve French <>, Paulo Alcantara <>,
        Ronnie Sahlberg <>,
        Shyam Prasad N <>,
        Tom Talpey <>,,,,
Subject: Re: [PATCH][next] cifs: Replace a couple of one-element arrays with
 flexible-array members

On Tue, Oct 04, 2022 at 08:51:39PM -0500, Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element arrays with flexible-array
> member in structs negotiate_req and extended_response, and refactor the
> rest of the code, accordingly.
> Also, make use of the DECLARE_FLEX_ARRAY() helper to declare flexible
> array member EncryptionKey in union u. This new helper allows for
> flexible-array members in unions.
> Change pointer notation to proper array notation in a call to memcpy()
> where flexible-array member DialectsArray is being used as destination
> argument.
> Important to mention is that doing a build before/after this patch results
> in no binary output differences.
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [1].
> Link:
> Link:
> Link: [1]
> Signed-off-by: Gustavo A. R. Silva <>

Looks good to me; thanks!

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists