linux-hardening - Re: [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2022 19:40:36 +0300
From:   Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
To:     Kees Cook <keescook@...omium.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
CC:     <intel-gfx@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <mchehab@...nel.org>,
        <chris@...is-wilson.co.uk>, <matthew.auld@...el.com>,
        <thomas.hellstrom@...ux.intel.com>, <jani.nikula@...el.com>,
        <nirmoy.das@...el.com>, <airlied@...hat.com>, <daniel@...ll.ch>,
        <andi.shyti@...ux.intel.com>, <andrzej.hajda@...el.com>,
        <mauro.chehab@...ux.intel.com>, <linux@...musvillemoes.dk>,
        <vitor@...saru.org>, <dlatypov@...gle.com>,
        <ndesaulniers@...gle.com>, <trix@...hat.com>,
        <llvm@...ts.linux.dev>, <linux-hardening@...r.kernel.org>,
        <linux-sparse@...r.kernel.org>, <nathan@...nel.org>,
        <gustavoars@...nel.org>, <luc.vanoostenryck@...il.com>
Subject: Re: [PATCH v13 5/9] drm/i915: Check for integer truncation on
 scatterlist creation

Linus and Kees, I also understood that I should not make and use the 
macro that performs assignment and checking at the same time, and I will 
drop it and update it.

Kees, the overflows_type() macro had several updates as input from you 
and the community, and there is an advantage when moving to Linux common.
What are your thoughts on continuing to add the overflows_type() macro 
to overflows.h?

Br,

G.G.

On 9/28/22 9:06 PM, Kees Cook wrote:
> On Wed, Sep 28, 2022 at 10:09:04AM -0700, Linus Torvalds wrote:
>> Kees, you need to reign in the craziness in overflow.h.
> 
> Understood. I've been trying to help the drm folks walk a line between
> having a bunch of custom macros hidden away in the drm includes and
> building up generalized versions that are actually helpful beyond drm.
> But I can see that it doesn't help to have a "do two things at the same
> time" macro for the assignment checking.
>