lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Oct 2022 09:44:29 +0200 From: Ard Biesheuvel <ardb@...nel.org> To: Peter Jones <pjones@...hat.com> Cc: Evgeniy Baskov <baskov@...ras.ru>, Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@...nel.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Alexey Khoroshilov <khoroshilov@...ras.ru>, lvc-project@...uxtesting.org, x86@...nel.org, linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH] efi/libstub: make memory protection warnings include newlines. On Tue, 18 Oct 2022 at 22:51, Peter Jones <pjones@...hat.com> wrote: > > efi_warn() doesn't put newlines on messages, and that makes reading > warnings without newlines hard to do. > > Signed-off-by: Peter Jones <pjones@...hat.com> OK, so this applies on top of Evgeniy's series, right? Do we need a version for 6.1-rc1 ? > --- > drivers/firmware/efi/libstub/mem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/efi/libstub/mem.c b/drivers/firmware/efi/libstub/mem.c > index 4d6c7f4fb7e..1b874096109 100644 > --- a/drivers/firmware/efi/libstub/mem.c > +++ b/drivers/firmware/efi/libstub/mem.c > @@ -293,7 +293,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, > rounded_end - rounded_start, > attr_clear); > if (status != EFI_SUCCESS) { > - efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx", > + efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx\n", > (unsigned long)rounded_start, > (unsigned long)rounded_end, > status); > @@ -306,7 +306,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, > rounded_end - rounded_start, > attributes); > if (status != EFI_SUCCESS) { > - efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx", > + efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx\n", > (unsigned long)rounded_start, > (unsigned long)rounded_end, > status); > -- > 2.37.1 >
Powered by blists - more mailing lists