lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Oct 2022 16:03:25 -0500 From: "Gustavo A. R. Silva" <gustavoars@...nel.org> To: Johannes Berg <johannes@...solutions.net> Cc: Stanislav Yakovlev <stas.yakovlev@...il.com>, Kalle Valo <kvalo@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2 1/6] cfg80211: Avoid clashing function prototypes On Fri, Oct 28, 2022 at 10:22:47AM +0200, Johannes Berg wrote: > Hm. > > If you're splitting out per driver, > > > +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c > > @@ -9870,7 +9870,7 @@ static int ipw_wx_sw_reset(struct net_device *dev, > > > > /* Rebase the WE IOCTLs to zero for the handler array */ > > static iw_handler ipw_wx_handlers[] = { > > - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname), > > + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname), > > I can see how this (and similar) still belongs into this patch since > it's related to the cfg80211 change, but > > > +++ b/drivers/net/wireless/intersil/orinoco/wext.c > > @@ -154,9 +154,10 @@ static struct iw_statistics *orinoco_get_wireless_stats(struct net_device *dev) > > > > static int orinoco_ioctl_setwap(struct net_device *dev, > > struct iw_request_info *info, > > - struct sockaddr *ap_addr, > > + union iwreq_data *wrqu, > > char *extra) > > { > > + struct sockaddr *ap_addr = &wrqu->ap_addr; > > why this (and similar) too? mmh... yeah; orinoco should be a separate patch. :) Thanks -- Gustavo
Powered by blists - more mailing lists