linux-hardening - Re: [PATCH] mips: boot/compressed: use __NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f976e6b-9e00-f6ce-fb95-7b7a21183b5d@linaro.org>
Date:   Mon, 31 Oct 2022 13:15:22 +0100
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     John Thomson <git@...nthomson.fastmail.com.au>,
        tsbogend@...ha.franken.de, keescook@...omium.org
Cc:     linux-mips@...r.kernel.org, linux-hardening@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] mips: boot/compressed: use __NO_FORITFY

On 30/10/22 19:36, John Thomson wrote:
> In the mips CONFIG_SYS_SUPPORTS_ZBOOT kernel, fix the compile error
> when using CONFIG_FORTIFY_SOURCE=y
> 
> LD      vmlinuz
> mipsel-openwrt-linux-musl-ld: arch/mips/boot/compressed/decompress.o: in
> function `decompress_kernel':
> ./include/linux/decompress/mm.h:(.text.decompress_kernel+0x177c):
> undefined reference to `warn_slowpath_fmt'
> 
> kernel test robot helped identify this as related to fortify. The error
> appeared with commit 54d9469bc515 ("fortify: Add run-time WARN for
> cross-field memcpy()")
> Link: https://lore.kernel.org/r/202209161144.x9xSqNQZ-lkp@intel.com/
> 
> Resolve this in the same style as commit cfecea6ead5f ("lib/string:
> Move helper functions out of string.c")
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 54d9469bc515 ("fortify: Add run-time WARN for cross-field memcpy()")
> Signed-off-by: John Thomson <git@...nthomson.fastmail.com.au>
> ---
> not sure about the fixes tag:
> compile error only occurs due to the fortify commit, but it looks like
> this change could have been part of the other commit identified in the
> message: lib/string move helper functions?
> ---
>   arch/mips/boot/compressed/decompress.c | 1 +
>   1 file changed, 1 insertion(+)

Typo "__NO_FORTIFY" in subject.