linux-hardening - Re: [PATCH v5] overflow: Introduce overflows_type() and castable_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211011605.2D8C927C2@keescook>
Date:   Tue, 1 Nov 2022 16:06:12 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
Cc:     arnd@...nel.org, mauro.chehab@...ux.intel.com,
        tvrtko.ursulin@...ux.intel.com, airlied@...ux.ie, trix@...hat.com,
        dlatypov@...gle.com, llvm@...ts.linux.dev, ndesaulniers@...gle.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        gustavoars@...nel.org, nathan@...nel.org,
        linux-sparse@...r.kernel.org, linux-hardening@...r.kernel.org,
        rodrigo.vivi@...el.com, mchehab@...nel.org,
        intel-gfx@...ts.freedesktop.org, luc.vanoostenryck@...il.com,
        vitor@...saru.org
Subject: Re: [PATCH v5] overflow: Introduce overflows_type() and
 castable_to_type()

On Sat, Oct 29, 2022 at 11:01:38AM +0300, Gwan-gyeong Mun wrote:
> 
> 
> On 10/29/22 10:32 AM, Kees Cook wrote:
> > On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote:
> > > Hi Kees,
> > 
> > Hi! :)
> > 
> > > I've updated to v5 with the last comment of Nathan.
> > > Could you please kindly review what more is needed as we move forward with
> > > this patch?
> > 
> > It looks fine to me -- I assume it'll go via the drm tree? Would you
> > rather I carry the non-drm changes in my tree instead?
> > 
> Hi!
> Yes, I think it would be better to run this patch on your tree.
> this patch moves the macro of i915 to overflows.h and modifies one part of
> drm's driver code, but I think this part can be easily applied when merging
> into the drm tree.

I've rebased it to the hardening tree, and it should appear in -next
shortly:

https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/hardening&id=5904fcb776d0b518be96bca43f258db90f26ba9a

-- 
Kees Cook