linux-hardening - Re: Coverity: get_md_pagetable(): Control flow issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2022 17:14:29 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     coverity-bot <keescook@...omium.org>
Cc:     Nicolin Chen <nicolinc@...dia.com>, Yi Liu <yi.l.liu@...el.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        linux-next@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: Coverity: get_md_pagetable(): Control flow issues

On Wed, Nov 02, 2022 at 12:57:33PM -0700, coverity-bot wrote:

> /drivers/iommu/iommufd/selftest.c: 248 in get_md_pagetable()
> 242     				 IOMMUFD_OBJ_HW_PAGETABLE);
> 243     	if (IS_ERR(obj))
> 244     		return ERR_CAST(obj);
> 245     	hwpt = container_of(obj, struct iommufd_hw_pagetable, obj);
> 246     	if (hwpt->domain->ops != mock_ops.default_domain_ops) {
> 247     		return ERR_PTR(-EINVAL);
> vvv     CID 1527089:  Control flow issues  (UNREACHABLE)
> vvv     This code cannot be reached: "iommufd_put_object(&hwpt->o...".
> 248     		iommufd_put_object(&hwpt->obj);
> 249     	}
> 250     	*mock = container_of(hwpt->domain, struct mock_iommu_domain, domain);
> 251     	return hwpt;
> 252     }
> 253
> 
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):

Yes, we already fixed this, thanks

Jason