lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Nov 2022 10:26:40 +0100 From: Rasmus Villemoes <rasmus.villemoes@...vas.dk> To: Kees Cook <keescook@...omium.org>, Vlastimil Babka <vbabka@...e.cz> Cc: Guenter Roeck <linux@...ck-us.net>, Andy Shevchenko <andriy.shevchenko@...el.com>, Paolo Abeni <pabeni@...hat.com>, Geert Uytterhoeven <geert@...ux-m68k.org>, David Gow <davidgow@...gle.com>, Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, Roman Gushchin <roman.gushchin@...ux.dev>, Hyeonggon Yoo <42.hyeyoo@...il.com>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, linux-hardening@...r.kernel.org, llvm@...ts.linux.dev Subject: Re: [PATCH 4/6] string: Add __realloc_size hint to kmemdup() On 01/11/2022 23.33, Kees Cook wrote: > Add __realloc_size() hint to kmemdup() so the compiler can reason about > the length of the returned buffer. (These must not use __alloc_size, > since those include __malloc which says the contents aren't defined[1]). > > [1] https://lore.kernel.org/linux-hardening/d199c2af-06af-8a50-a6a1-00eefa0b67b4@prevas.dk/ > > extern char *kstrndup(const char *s, size_t len, gfp_t gfp); > -extern void *kmemdup(const void *src, size_t len, gfp_t gfp) __alloc_size(2); > +extern void *kmemdup(const void *src, size_t len, gfp_t gfp) __realloc_size(2); What tree is this based on? I see that kmemdup() has grown that bogus __alloc_size in next-20221101, but in next-20221102 this commit seems to DTRT, namely -extern void *kmemdup(const void *src, size_t len, gfp_t gfp); +extern void *kmemdup(const void *src, size_t len, gfp_t gfp) __realloc_size(2); (i.e. there should never be an intermediate commit where kmemdup has __alloc_size()). Rasmus
Powered by blists - more mailing lists