linux-hardening - Re: [PATCH v2] mips: boot/compressed: use __NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2022 16:05:51 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     John Thomson <git@...nthomson.fastmail.com.au>
Cc:     keescook@...omium.org, linux-mips@...r.kernel.org,
        linux-hardening@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] mips: boot/compressed: use __NO_FORTIFY

On Tue, Nov 01, 2022 at 03:07:49AM +1000, John Thomson wrote:
> In the mips CONFIG_SYS_SUPPORTS_ZBOOT kernel, fix the compile error
> when using CONFIG_FORTIFY_SOURCE=y
> 
> LD      vmlinuz
> mipsel-openwrt-linux-musl-ld: arch/mips/boot/compressed/decompress.o: in
> function `decompress_kernel':
> ./include/linux/decompress/mm.h:(.text.decompress_kernel+0x177c):
> undefined reference to `warn_slowpath_fmt'
> 
> kernel test robot helped identify this as related to fortify. The error
> appeared with commit 54d9469bc515 ("fortify: Add run-time WARN for
> cross-field memcpy()")
> Link: https://lore.kernel.org/r/202209161144.x9xSqNQZ-lkp@intel.com/
> 
> Resolve this in the same style as commit cfecea6ead5f ("lib/string:
> Move helper functions out of string.c")
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 54d9469bc515 ("fortify: Add run-time WARN for cross-field memcpy()")
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: John Thomson <git@...nthomson.fastmail.com.au>
> ---
> v2:
> fix subject typo: FORITFY->FORTIFY
> ---
>  arch/mips/boot/compressed/decompress.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/boot/compressed/decompress.c b/arch/mips/boot/compressed/decompress.c
> index 5b38a802e101..c5dd415254d3 100644
> --- a/arch/mips/boot/compressed/decompress.c
> +++ b/arch/mips/boot/compressed/decompress.c
> @@ -9,6 +9,7 @@
>  
>  #define DISABLE_BRANCH_PROFILING
>  
> +#define __NO_FORTIFY
>  #include <linux/types.h>
>  #include <linux/kernel.h>
>  #include <linux/string.h>
> -- 
> 2.37.2

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]