linux-hardening - Re: [PATCH][next] RDMA/erdma: Replace zero-length arrays with flexible-array members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2023 19:15:15 +0800
From:   Cheng Xu <chengyou@...ux.alibaba.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Kai Shen <kaishen@...ux.alibaba.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] RDMA/erdma: Replace zero-length arrays with
 flexible-array members



On 1/10/23 9:40 AM, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members instead. So, replace zero-length
> arrays, in a couple of structures, with flex-array members.
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
>  drivers/infiniband/hw/erdma/erdma_hw.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Cheng Xu <chengyou@...ux.alibaba.com>

Thanks very much,
Cheng Xu


> diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h
> index ab371fec610c..4c38d99c73f1 100644
> --- a/drivers/infiniband/hw/erdma/erdma_hw.h
> +++ b/drivers/infiniband/hw/erdma/erdma_hw.h
> @@ -397,7 +397,7 @@ struct erdma_write_sqe {
>  
>  	__le32 rsvd;
>  
> -	struct erdma_sge sgl[0];
> +	struct erdma_sge sgl[];
>  };
>  
>  struct erdma_send_sqe {
> @@ -408,7 +408,7 @@ struct erdma_send_sqe {
>  	};
>  
>  	__le32 length;
> -	struct erdma_sge sgl[0];
> +	struct erdma_sge sgl[];
>  };
>  
>  struct erdma_readreq_sqe {