linux-hardening - RE: Coverity: dm_dmub_sw_init(): Incorrect expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 22:39:20 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     coverity-bot <keescook@...omium.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Li, Roman" <Roman.Li@....com>, "Zuo, Jerry" <Jerry.Zuo@....com>,
        "Wu, Hersen" <hersenxs.wu@....com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Lazar, Lijo" <Lijo.Lazar@....com>,
        "Pillai, Aurabindo" <Aurabindo.Pillai@....com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...il.com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "Wheeler, Daniel" <Daniel.Wheeler@....com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: RE: Coverity: dm_dmub_sw_init(): Incorrect expression

[AMD Official Use Only - General]

This particular one was fixed already in https://patchwork.freedesktop.org/patch/518050/ which got applied today.

> -----Original Message-----
> From: coverity-bot <keescook@...omium.org>
> Sent: Thursday, January 12, 2023 16:25
> To: Limonciello, Mario <Mario.Limonciello@....com>
> Cc: linux-kernel@...r.kernel.org; amd-gfx@...ts.freedesktop.org; Siqueira,
> Rodrigo <Rodrigo.Siqueira@....com>; Li, Sun peng (Leo)
> <Sunpeng.Li@....com>; Li, Roman <Roman.Li@....com>; Zuo, Jerry
> <Jerry.Zuo@....com>; Wu, Hersen <hersenxs.wu@....com>; dri-
> devel@...ts.freedesktop.org; Koenig, Christian <Christian.Koenig@....com>;
> Lazar, Lijo <Lijo.Lazar@....com>; Pillai, Aurabindo
> <Aurabindo.Pillai@....com>; Wentland, Harry <Harry.Wentland@....com>;
> Deucher, Alexander <Alexander.Deucher@....com>; Daniel Vetter
> <daniel@...ll.ch>; David Airlie <airlied@...il.com>; Pan, Xinhui
> <Xinhui.Pan@....com>; Wheeler, Daniel <Daniel.Wheeler@....com>;
> Gustavo A. R. Silva <gustavo@...eddedor.com>; linux-next@...r.kernel.org;
> linux-hardening@...r.kernel.org
> Subject: Coverity: dm_dmub_sw_init(): Incorrect expression
> 
> Hello!
> 
> This is an experimental semi-automated report about issues detected by
> Coverity from a scan of next-20230111 as part of the linux-next scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
> 
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by commits:
> 
>   Tue Jan 10 14:32:57 2023 -0500
>     a7ab345149b8 ("drm/amd/display: Load DMUB microcode during early_init")
> 
> Coverity reported the following:
> 
> *** CID 1530544:  Incorrect expression  (IDENTICAL_BRANCHES)
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1951 in
> dm_dmub_sw_init()
> 1945
> 1946     	switch (adev->ip_versions[DCE_HWIP][0]) {
> 1947     	case IP_VERSION(2, 1, 0):
> 1948     		dmub_asic = DMUB_ASIC_DCN21;
> 1949     		break;
> 1950     	case IP_VERSION(3, 0, 0):
> vvv     CID 1530544:  Incorrect expression  (IDENTICAL_BRANCHES)
> vvv     The same code is executed regardless of whether "adev-
> >ip_versions[GC_HWIP][0] == 656128U" is true, because the 'then' and 'else'
> branches are identical. Should one of the branches be modified, or the entire 'if'
> statement replaced?
> 1951     		if (adev->ip_versions[GC_HWIP][0] == IP_VERSION(10, 3, 0))
> 1952     			dmub_asic = DMUB_ASIC_DCN30;
> 1953     		else
> 1954     			dmub_asic = DMUB_ASIC_DCN30;
> 1955     		break;
> 1956     	case IP_VERSION(3, 0, 1):
> 
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
> 
> Reported-by: coverity-bot <keescook+coverity-bot@...omium.org>
> Addresses-Coverity-ID: 1530544 ("Incorrect expression")
> Fixes: a7ab345149b8 ("drm/amd/display: Load DMUB microcode during
> early_init")
> 
> Thanks for your attention!
> 
> --
> Coverity-bot